Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a TODO for kubeconfig rotation #122

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

nasusoba
Copy link
Contributor

@nasusoba nasusoba commented May 23, 2024

  • Fix a TODO for rotating kubeconfig secret if it is close to expiring
    • When created, kubeconfig secret will be effective for a year. If kubeconfig secret will expired in 180 days, it will get rotated
  • Address RestConfig creation failure as RemoteClusterConnectionError (same as CAPI)

I have manually verified the cert could be rotated and the rotated secret could still be used to connect to the workload cluster.

Signed-off-by: nasusoba <[email protected]>
@mogliang mogliang merged commit a3067a7 into k3s-io:main May 29, 2024
5 checks passed
@nasusoba nasusoba deleted the kubeconfig2 branch May 29, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants